Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulp ostree: composer should check pulp config before start to build image #3674

Open
yih-redhat opened this issue Sep 6, 2023 · 1 comment

Comments

@yih-redhat
Copy link
Contributor

Describe the bug
When pulp enabled, composer will build image first and then upload image to pulp, this could cause a potential issue, that if customer provided wrong pulp information in pulp.toml, composer will still build the image first but will fail at upload step.
Composer should deny the request if pulp configuration is wrong, just like what it did for --url parameter.

Environment

  • OS version (/etc/os-release and /etc/redhat-release):
  • osbuild-composer version (rpm -qi osbuild-composer)

To Reproduce
Steps to reproduce the behavior:

  • for example starting osbuild-composer.service or running composer-cli command, don't forget to include all configuration files you created

Expected behavior
A clear and concise description of what you expected to happen.

Additional context
Add any other context about the problem here.

@achilleas-k
Copy link
Member

The behaviour with the pulp uploader is the same as it is for all other uploaders/targets. Maybe this can be a more general change for verifying upload configurations before a build, if we want to go this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants