Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: lighter SSRF migration #641

Merged
merged 1 commit into from Dec 1, 2022
Merged

feat: lighter SSRF migration #641

merged 1 commit into from Dec 1, 2022

Conversation

hperl
Copy link
Collaborator

@hperl hperl commented Nov 28, 2022

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@hperl hperl force-pushed the hperl/lighter-ssrf-mitigation branch 3 times, most recently from d65479f to 6417e48 Compare November 28, 2022 14:39
@hperl hperl marked this pull request as ready for review November 30, 2022 08:08
@hperl hperl requested a review from aeneasr November 30, 2022 08:08
@hperl hperl force-pushed the hperl/lighter-ssrf-mitigation branch 2 times, most recently from 99f396c to f6c6526 Compare November 30, 2022 08:09
aeneasr
aeneasr reviewed Nov 30, 2022
View reviewed changes
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice clean-up

httpx/private_ip_validator.go Show resolved Hide resolved
@hperl hperl force-pushed the hperl/lighter-ssrf-mitigation branch from f6c6526 to 33e13f6 Compare November 30, 2022 13:29
@hperl hperl self-assigned this Nov 30, 2022
@hperl hperl requested a review from aeneasr November 30, 2022 13:33
@aeneasr aeneasr merged commit d5dfdaa into master Dec 1, 2022
@aeneasr aeneasr deleted the hperl/lighter-ssrf-mitigation branch December 1, 2022 08:31
aeneasr added a commit that referenced this pull request Jan 10, 2023
@aeneasr
revert: lighter SSRF migration (#641)
1a77335
aeneasr added a commit that referenced this pull request Jan 10, 2023
@aeneasr
revert: lighter SSRF migration (#641)
ab12091
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeneasr aeneasr Awaiting requested review from aeneasr

Assignees

@hperl hperl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hperl @aeneasr