Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpdateRecoveryFlowWithHttpInfoAsync does not return cookies on completion due to an exception being thrown #294

Open
4 of 5 tasks
thomasFarley1991 opened this issue Sep 27, 2023 · 1 comment
Labels
bug Something is not working.

Comments

@thomasFarley1991
Copy link

thomasFarley1991 commented Sep 27, 2023

Preflight checklist

Ory Network Project

No response

Describe the bug

The UpdateRecoveryFlowWithHttpInfoAsync returns a status of 422 when I responds to redirect the browser to the settings flow.

However because the default exception factory throws an exception for anything with a code > 400 the cookies do not get returned. This means you cannot continue with the settings journey as you have no ory session.

Reproducing the bug

  1. CreateBrowserRecoveryFlowWithHttpInfoAsync (code method)
  2. UpdateRecoveryFlowWithHttpInfoAsync (with email)
  3. UpdateRecoveryFlowWithHttpInfoAsync (with code to complete)
  4. Completed flow returns an exception with no cookies.
  5. Redirect to settings ui
  6. Can't get settings flow as no ory session cookie

Relevant log output

No response

Relevant configuration

No response

Version

1.2.9

On which operating system are you observing this issue?

macOS / dotnet SDK

In which environment are you deploying?

None

Additional Context

No response

@thomasFarley1991 thomasFarley1991 added the bug Something is not working. label Sep 27, 2023
@jonas-jonas
Copy link
Collaborator

Thanks! Likely requires an update to the generator, or we provide a custom exception factory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

No branches or pull requests

2 participants