Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation of protobufs is broken with multiline comments #1537

Open
3 of 5 tasks
constantoine opened this issue Sep 18, 2023 · 2 comments
Open
3 of 5 tasks

Documentation of protobufs is broken with multiline comments #1537

constantoine opened this issue Sep 18, 2023 · 2 comments
Labels
bug Something is not working. upstream Issue is caused by an upstream dependency.

Comments

@constantoine
Copy link

constantoine commented Sep 18, 2023

Preflight checklist

Ory Network Project

No response

Describe the bug

Documentation generated from protobuf files which contain a newline will generate a broken table.

Reproducing the bug

run: make buf inside the keto project. The generated file docs/.generated/proto-api.mdx is well formated. Tables contain newlines with </br> tags. The file protof/buf.md does not.

Open the docs/keto/reference/proto-api.mdx file inside the docs project. The tables now contain actual newlines, breaking the tables, and resulting in garbled docs

Relevant log output

No response

Relevant configuration

No response

Version

keto v0.11.1-alpha.0

On which operating system are you observing this issue?

None

In which environment are you deploying?

None

Additional Context

No response

@constantoine constantoine added the bug Something is not working. label Sep 18, 2023
@constantoine
Copy link
Author

I believe the issue is caused by the buf tool. I'm looking into ways of configuring this, but the docs of buf are not helping a lot for markdown table generation

@constantoine
Copy link
Author

Caused by pseudomuto/protoc-gen-doc#274

@vinckr vinckr added the upstream Issue is caused by an upstream dependency. label Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working. upstream Issue is caused by an upstream dependency.
Projects
None yet
Development

No branches or pull requests

2 participants