Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
1. Port bindings
Using the docker container from outside via endpoint
localhost:9000
did not work for me until I changed the port binding from this"9000": []dc.PortBinding{{HostPort: "9000"}}
to this
"9000/tcp": []dc.PortBinding{{HostPort: "9000"}}
These is the output of
docker ps
for the first caseThese is the output of
docker ps
for the second case2. Connection check
The code inside
retry
function does not check if the connection can be established. The client does not do that by itself, you have to check it using health endpoint. See this issue.Checklist
and signed the CLA.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
appropriate).