Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minio example #244

Merged
merged 1 commit into from Dec 11, 2020
Merged

fix: minio example #244

merged 1 commit into from Dec 11, 2020

Conversation

ivancili
Copy link
Contributor

@ivancili ivancili commented Dec 11, 2020

Proposed changes

1. Port bindings

Using the docker container from outside via endpoint localhost:9000 did not work for me until I changed the port binding from this
"9000": []dc.PortBinding{{HostPort: "9000"}}
to this
"9000/tcp": []dc.PortBinding{{HostPort: "9000"}}

These is the output of docker ps for the first case

CONTAINER ID   IMAGE                COMMAND                  CREATED        STATUS                  PORTS                     NAMES
973bf9d3cfb4   minio/minio:latest   "/usr/bin/docker-ent…"   1 second ago   Up Less than a second   0.0.0.0:55011->9000/tcp   compassionate_goldstine

These is the output of docker ps for the second case

CONTAINER ID   IMAGE                COMMAND                  CREATED         STATUS        PORTS                    NAMES
8695933e461c   minio/minio:latest   "/usr/bin/docker-ent…"   2 seconds ago   Up 1 second   0.0.0.0:9000->9000/tcp   pensive_jones

2. Connection check

The code inside retry function does not check if the connection can be established. The client does not do that by itself, you have to check it using health endpoint. See this issue.

Checklist

  • I have read the contributing guidelines
    and signed the CLA.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added necessary documentation within the code base (if
    appropriate).

@CLAassistant
Copy link

CLAassistant commented Dec 11, 2020

CLA assistant check
All committers have signed the CLA.

@aeneasr
Copy link
Member

aeneasr commented Dec 11, 2020

LMK when this is ready for 👀

@ivancili ivancili marked this pull request as ready for review December 11, 2020 13:04
@ivancili
Copy link
Contributor Author

I just signed the CLA, no other things to add

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🎉

Thank you for your contribution!

@aeneasr aeneasr merged commit c7ad119 into ory:v3 Dec 11, 2020
@ivancili ivancili deleted the fix/minio-example branch December 11, 2020 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants