Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BuildArgs to BuildOptions #242

Closed
potix2 opened this issue Dec 2, 2020 · 0 comments
Closed

Add BuildArgs to BuildOptions #242

potix2 opened this issue Dec 2, 2020 · 0 comments

Comments

@potix2
Copy link
Contributor

potix2 commented Dec 2, 2020

Is your feature request related to a problem? Please describe.

I want to pass additional values as BuildArg on building an image. But currently dockertest doesn't have such an interface.

Describe the solution you'd like

I want to add BuildOptions.BuildArgs to pass the building time arguments.

Describe alternatives you've considered

If I call Pool.Client.BuildImage() directly, I can use BuildArg to build an image. But I have to write additional code to run my customized image and it has to follow dockertest code to keep consistency with dockertest API.

Additional context

Nothing.

potix2 added a commit to potix2/dockertest that referenced this issue Dec 3, 2020
@aeneasr aeneasr closed this as completed in c265f43 Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant