Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tunnel asks to open application from browser on login/registration flow requiring redirects #236

Open
6 tasks done
Benehiko opened this issue Oct 6, 2022 · 6 comments
Open
6 tasks done
Labels
bug Something is not working.

Comments

@Benehiko
Copy link
Contributor

Benehiko commented Oct 6, 2022

Preflight checklist

Describe the bug

On any flow that requires a browser redirect the browser will ask to open an application instead of doing the redirect.

For example:

A login flow
image

A registration flow
image

On logout we have the same problem
image

Flows not affected

  • Recovery
  • Verification

I have also tested this on SPA applications which have no redirects on login, registration etc. However on logout we redirect to Kratos which opens the dialog.

Reproducing the bug

  1. spin tunnel up on localhost:4000
  2. start node express app on localhost:3000
  3. do a login/registration flow by visiting localhost:3000
  4. the browser will ask to open a new application

Relevant log output

No response

Relevant configuration

No response

Version

v0.1.43

On which operating system are you observing this issue?

Linux

In which environment are you deploying?

Ory Cloud

Additional Context

No response

@Benehiko Benehiko added the bug Something is not working. label Oct 6, 2022
@aeneasr
Copy link
Member

aeneasr commented Oct 6, 2022

I can't reproduce this. Is the problem maybe the changes you have made to the node app?

@Benehiko
Copy link
Contributor Author

Benehiko commented Oct 6, 2022

I can't reproduce this. Is the problem maybe the changes you have made to the node app?

this also happens with the elements/react-spa example on logout. so i don't think it's related to the implementation.

@aeneasr
Copy link
Member

aeneasr commented Oct 6, 2022

I'm trying the examples from the docs and can not reproduce the problem! E2E tests for proxy are also passing

@Benehiko
Copy link
Contributor Author

Benehiko commented Oct 6, 2022

I will try with the docs examples as well quick.

The problem is with tunnel afaik - haven't tried proxy - and the e2e tests in docs do not test against tunnel.

@aeneasr
Copy link
Member

aeneasr commented Oct 6, 2022

I tested it with the tunnel and the React app. The e2e tests in Ory CLI test both proxy and tunnel :)

@Benehiko
Copy link
Contributor Author

Benehiko commented Oct 7, 2022

Tested this on another machine and it seems to work normally... not really sure what's different in my environment that could cause this 🤔

I will investigate it a bit later and report back here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

No branches or pull requests

2 participants