Unit tests don't work if expressions are not compiled

[marvkis]

Hi,

most of the unit tests are only tested against compiled OGNL expressions. When we do the unit-tests against interpreded and compiled expressions, we see that a lot of unit tests fail:

Results :

Failed tests:
  myMap[null](org.ognl.test.InterfaceInheritanceTest)
  beans.evenOdd.next(org.ognl.test.InterfaceInheritanceTest)
  #root[1](org.ognl.test.ArrayElementsTest)
  intValue(org.ognl.test.ArrayElementsTest)
  array(org.ognl.test.ArrayElementsTest)
  floatValue(org.ognl.test.NumberFormatExceptionTest)
  intValue(org.ognl.test.NumberFormatExceptionTest)
  intValue(org.ognl.test.NumberFormatExceptionTest)
  bigIntValue(org.ognl.test.NumberFormatExceptionTest)
  bigIntValue(org.ognl.test.NumberFormatExceptionTest)
  bigDecValue(org.ognl.test.NumberFormatExceptionTest)
  bigDecValue(org.ognl.test.NumberFormatExceptionTest)
  intValue(org.ognl.test.PropertyTest)
  booleanValue(org.ognl.test.PropertyTest)
  'disableButton(this,"' + map.get('button-testing') + '");clearElement("testFtpMessage")'(org.ognl.test.PropertyTest)
  ids (null)(org.ognl.test.GenericsTest)
  stringValue(org.ognl.test.MethodWithConversionTest)
  values[1](org.ognl.test.IndexedPropertyTest)
  property['hoodak'](org.ognl.test.IndexedPropertyTest)
  newValue(org.ognl.test.SetterTest)
  settableList[0](org.ognl.test.SetterTest)
  settableList[2](org.ognl.test.SetterTest)
  settableList[$](org.ognl.test.SetterTest)
  settableList[^](org.ognl.test.SetterTest)
  settableList[|](org.ognl.test.SetterTest)
  map.newValue(org.ognl.test.SetterTest)
  map.(someMissingKey || newValue)(org.ognl.test.SetterTest)
  map.(newValue && aKey)(org.ognl.test.SetterTest)
  map[0]="map.newValue", map[0](#this)(org.ognl.test.SetterTest)
  openTransitionWin(org.ognl.test.SetterTest)
  --1f (1.0)(org.ognl.test.ArithmeticAndLogicalOperatorsTest)
  5f-2F (3.0)(org.ognl.test.ArithmeticAndLogicalOperatorsTest)
  -1b (-1)(org.ognl.test.ArithmeticAndLogicalOperatorsTest)
  +1b (1)(org.ognl.test.ArithmeticAndLogicalOperatorsTest)
  --1b (1)(org.ognl.test.ArithmeticAndLogicalOperatorsTest)
  2*2.0b (4.0)(org.ognl.test.ArithmeticAndLogicalOperatorsTest)
  5/2.B (2)(org.ognl.test.ArithmeticAndLogicalOperatorsTest)
  5.0B/2 (2.5)(org.ognl.test.ArithmeticAndLogicalOperatorsTest)
  5+2b (7)(org.ognl.test.ArithmeticAndLogicalOperatorsTest)
  5-2B (3)(org.ognl.test.ArithmeticAndLogicalOperatorsTest)
  5.+2b*3 (11.0)(org.ognl.test.ArithmeticAndLogicalOperatorsTest)
  (5.+2b)*3 (21.0)(org.ognl.test.ArithmeticAndLogicalOperatorsTest)
  5. & 3 (1)(org.ognl.test.ArithmeticAndLogicalOperatorsTest)
  5&(3|5^3) (5)(org.ognl.test.ArithmeticAndLogicalOperatorsTest)
  -1h (-1)(org.ognl.test.ArithmeticAndLogicalOperatorsTest)
  +1H (1)(org.ognl.test.ArithmeticAndLogicalOperatorsTest)
  --1h (1)(org.ognl.test.ArithmeticAndLogicalOperatorsTest)
  2h*2 (4)(org.ognl.test.ArithmeticAndLogicalOperatorsTest)
  5/2h (2)(org.ognl.test.ArithmeticAndLogicalOperatorsTest)
  5h+2 (7)(org.ognl.test.ArithmeticAndLogicalOperatorsTest)
  5-2h (3)(org.ognl.test.ArithmeticAndLogicalOperatorsTest)
  5+2H*3 (11)(org.ognl.test.ArithmeticAndLogicalOperatorsTest)
  (5+2H)*3 (21)(org.ognl.test.ArithmeticAndLogicalOperatorsTest)
  ~1h (-2)(org.ognl.test.ArithmeticAndLogicalOperatorsTest)
  5h%2 (1)(org.ognl.test.ArithmeticAndLogicalOperatorsTest)
  5h<<2 (20)(org.ognl.test.ArithmeticAndLogicalOperatorsTest)
  5h>>2 (1)(org.ognl.test.ArithmeticAndLogicalOperatorsTest)
  5h>>1+1 (1)(org.ognl.test.ArithmeticAndLogicalOperatorsTest)
  -5h>>>2 (-2)(org.ognl.test.ArithmeticAndLogicalOperatorsTest)
  5.b & 3 (1)(org.ognl.test.ArithmeticAndLogicalOperatorsTest)
  5h ^3 (6)(org.ognl.test.ArithmeticAndLogicalOperatorsTest)
  5h&3|5^3 (7)(org.ognl.test.ArithmeticAndLogicalOperatorsTest)
  5H&(3|5^3) (5)(org.ognl.test.ArithmeticAndLogicalOperatorsTest)
  1 band 0 (0)(org.ognl.test.ArithmeticAndLogicalOperatorsTest)
  attribute["bar"](org.ognl.test.ObjectIndexedPropertyTest)
  1234L (1234)(org.ognl.test.ConstantTest)
  12.34f (12.34)(org.ognl.test.ConstantTest)
  intValue(org.ognl.test.SetterWithConversionTest)
  intValue(org.ognl.test.SetterWithConversionTest)
  intValue(org.ognl.test.SetterWithConversionTest)
  stringValue(org.ognl.test.SetterWithConversionTest)
  stringValue(org.ognl.test.SetterWithConversionTest)
  anotherStringValue(org.ognl.test.SetterWithConversionTest)
  anotherStringValue(org.ognl.test.SetterWithConversionTest)
  anotherIntValue(org.ognl.test.SetterWithConversionTest)
  anotherIntValue(org.ognl.test.SetterWithConversionTest)
  tab.searchCriteriaSelections[index1][index2](org.ognl.test.IndexAccessTest)
  map['bar'].value(org.ognl.test.IndexAccessTest)
  thing["x"].val(org.ognl.test.IndexAccessTest)
  messages.format('ShowAllCount', {one}) (foo)(org.ognl.test.MethodTest)
  messages.format('ShowAllCount', {one, two}) (foo)(org.ognl.test.MethodTest)
  floatValue(org.ognl.test.PrimitiveNullHandlingTest)
  intValue(org.ognl.test.PrimitiveNullHandlingTest)
  booleanValue(org.ognl.test.PrimitiveNullHandlingTest)
  booleanValue(org.ognl.test.PrimitiveNullHandlingTest)

Tests in error:
  getValues(org.ognl.test.IndexedPropertyTest)
  testMethods.getBean('TestBean') (NamedBean: TestBean)(org.ognl.test.MethodTest)
  testMethods.testProperty (Hello World!)(org.ognl.test.MethodTest)

Tests run: 735, Failures: 85, Errors: 3, Skipped: 0

diff --git a/src/test/java/org/ognl/test/OgnlTestCase.java b/src/test/java/org/ognl/test/OgnlTestCase.java
index 5639350..dac2238 100644
--- a/src/test/java/org/ognl/test/OgnlTestCase.java
+++ b/src/test/java/org/ognl/test/OgnlTestCase.java
@@ -194,6 +194,25 @@ public class OgnlTestCase extends TestCase {
         try {
             SimpleNode expr;

+            if (_compileExpressions) {
+                // round 1 - parse only
+                _compileExpressions = false;
+                testedResult = _expectedResult;
+                expr = getExpression();
+
+                assertEquals(_expectedResult, Ognl.getValue(expr, _context, _root));
+
+                if (hasSetValue)
+                {
+                    testedResult = hasExpectedAfterSetResult ? expectedAfterSetResult : setValue;
+                    Ognl.setValue(expr, _context, _root, setValue);
+
+                    assertEquals(testedResult, Ognl.getValue(expr, _context, _root));
+                }
+                // round two - compile expressions
+                _compileExpressions = true;
+            }
+
             testedResult = _expectedResult;
             expr = getExpression();

Might be a thing for OGNL-4 ?

[lukaszlenart]

I think so ...