Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support schema registry in kafka preset #672

Merged
merged 1 commit into from Sep 27, 2022
Merged

Support schema registry in kafka preset #672

merged 1 commit into from Sep 27, 2022

Conversation

orlangure
Copy link
Owner

Schema registry startup time is a bit longer than the broker, so registry usage is hidden behind a flag to not make existing tests slower.

@orlangure orlangure self-assigned this Sep 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2022

Codecov Report

Base: 85.97% // Head: 85.88% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (d9a95e6) compared to base (d8fc13b).
Patch coverage: 71.42% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #672      +/-   ##
==========================================
- Coverage   85.97%   85.88%   -0.09%     
==========================================
  Files          49       49              
  Lines        2267     2281      +14     
==========================================
+ Hits         1949     1959      +10     
- Misses        165      167       +2     
- Partials      153      155       +2     
Impacted Files Coverage Δ
preset/kafka/preset.go 79.10% <63.63%> (-1.39%) ⬇️
preset/kafka/options.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Schema registry startup time is a bit longer than the broker, so
registry usage is hidden behind a flag to not make existing tests
slower.
@orlangure orlangure merged commit d7885f7 into master Sep 27, 2022
@orlangure orlangure deleted the kafka-registry branch September 27, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants