Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Configurable Docker Registry URL #1023

Open
andrewggg1 opened this issue Nov 9, 2023 · 3 comments
Open

Feature: Configurable Docker Registry URL #1023

andrewggg1 opened this issue Nov 9, 2023 · 3 comments

Comments

@andrewggg1
Copy link

Hi All,

Just wondering if you guys have planned to have a docker registry URL? Due to the maximum limits of pulling from docker host, it would be nice if we can configure it with our own cached registry instead of directly accessing it from docker hub

Thanks!

@orlangure
Copy link
Owner

Hi @andrewggg1 and sorry for taking so long to address this.

Right now there is no "concept" of a registry, because every preset defines its own image which includes docker registry URL. Some images are already not hosted on docker.io (like mssql).

As a quick workaround, before anybody gets to work on this issue, I can suggest writing a wrapper Preset for whatever presets you require in tests, and implementing Image method to return your custom registry hosted image. It's very little code, and you will still enjoy all the new features of the wrapped presets if ever added.

As a more generic solution, I only can think of using some string manipulation magic that replaces docker.io or any other registry host name by the provided URL from a new Options function. It would be the users' job to verify that the provided registry actually hosts the requested image.

I'm out of capacity in the near future to work on this, but I am available to review code and release a new version if you or anybody else is willing to take on the generic solution part. Would you like to work on this?

@mingmingshiliyu
Copy link

what should I do if I don`t want to use docker,but use the client itself? just skip start function?

@orlangure
Copy link
Owner

Hi @mingmingshiliyu, sorry, I don't understand the question. Which client do you want to use?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants