Add get_mut() to maps #52
Conversation
arthurprs
force-pushed
the
get_mut
branch
2 times, most recently
from
09da45f
to
e8bed47
Compare
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
==========================================
- Coverage 93.24% 92.83% -0.41%
==========================================
Files 11 11
Lines 1583 1620 +37
==========================================
+ Hits 1476 1504 +28
- Misses 107 116 +9
Continue to review full report at Codecov.
|
| Bucket::Single(_) => None, | ||
| Bucket::Collision(entries) => { | ||
| let removed = | ||
| bucket_utils::list_remove_first(entries, |e| e.matches(key, key_hash)); |
There was a problem hiding this comment.
We could do this more efficiently, but I don't think we care, given that collisions are extremely rare.
There was a problem hiding this comment.
Yeah, it shouldn't matter in practice. I thought about doing it the "right way" but it would change a lot more code due to the limited api for the list. Doing this way I got away with just "first_mut".
With it the user can avoid the clunky pattern get() + modify + insert().
|
Merged. Thanks. |
|
I was hoping you could make a new release? That will include the rand 0.8 update and the get_mut. Thank you 🙏 |
|
Sure. Released v0.9.0. |
With it the user can avoid the clunky pattern get() + clone + modify + insert(). Especially useful if you have early returns (eg. with
?) in between.