Multiple files with spec: files not supported in conditions of kind:file

[macedogm]

Is there a reason why spec:files > 1 isn't supported in conditions of kind: file but is supported in targets? See

updatecli/pkg/plugins/resources/file/condition.go

Lines 53 to 58 in 1c37a46

	func (f *File) condition(source string) (bool, error) {
	var validationErrors []string
	if len(f.files) > 1 {
	validationErrors = append(validationErrors, "Validation error in conditions of type 'file': the attributes `spec.files` can't contain more than one element for conditions")
	}

My use case is to simplify detection of patterns, for example, instead of doing this multiple times with kind: "dockerfile", one for each file:

conditions:
  dockerfile-dapper:
    name: "Check if 'ARG GOLANG' is set in Dockerfile.dapper"
    kind: "dockerfile"
    scmid: "k3s"
    sourceid: "golang-alpine-docker-image"
    spec:
      file: "Dockerfile.dapper"
      instruction:
        keyword: "ARG"
        matcher: "GOLANG"
  dockerfile-test:
    name: "Check if 'ARG GOLANG' is set in Dockerfile.test"
    kind: "dockerfile"
    scmid: "k3s"
    sourceid: "golang-alpine-docker-image"
    spec:
      file: "Dockerfile.test"
      instruction:
        keyword: "ARG"
        matcher: "GOLANG"

We could simplify it with:

conditions:
  dockerfiles:
    name: "Bump golang:alpine image version in Dockerfiles"
    kind: "file"
    scmid: "k3s"
    disablesourceinput: true
    spec:
      files:
        - "Dockerfile.dapper"
        - "Dockerfile.test"
        - "Dockerfile.manifest"
      matchpattern: 'ARG GOLANG=golang:v?\d+\.\d+\.\d+(-alpine\S+)?'

Because this functionality is already partially available in kind: "file". Another option would be to add support to spec: files to kind: "dockerfile", but this would require extra code. kind: "file" with matchpattern is really powerful IMO.

[olblak]

I can't think of any valid reason to restrict that functionality in the condition of type File. Especially considering that we implemented similar behavior for other resources like json,toml,csv,etc.

Maybe @hervelemeur recall something but I would bet on a lack of time or feature need at that time.

If you feel comfortable with it, feel free to open a PR as I definitely see a need for that now that I started looking in github.com/updatecli/updatemonitor

[lemeurherve]

Lack of time indeed, the creation of the corresponding pull request took a lot of time I wanted to ship it.

[macedogm]

Understood. From the quick test that I did, for the use case presented above, just removing the following lines made it work as expected.

updatecli/pkg/plugins/resources/file/condition.go

Lines 56 to 58 in 1c37a46

	if len(f.files) > 1 {
	validationErrors = append(validationErrors, "Validation error in conditions of type 'file': the attributes `spec.files` can't contain more than one element for conditions")
	}

I'll do a deeper look for side effects and provide a PR during the week.

[lemeurherve]

That should be about it :)

If I remember correctly, I've got some test errors and out of motivation to fix them at that time.

[macedogm]

Please see related issue #1026 and PR #1027.

[macedogm]

With the PR merged, we should be able to close this discussion I guess.