fix(edit): Avoid leading newline on first nested table #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When making a table pretty, we try to put newlines between tables. Since the decor is tracked in each table, we have to protect against that newline being at the start of the document. Before, we only checked if the first item in the document was a table but we didn't check if that table is visible. Now we watch for the first visible table for removing the newline.
This makes the newline skipping available to everyone and not just if you run `to_string_pretty`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to_string_prettytries to have newlines between tables but not extra leading/trailing newlines. The leading newline logic was only working if the first table was visible. If it was not visible, we put a newline before the first dotted table.Now we avoid the newline before the first table, of any kind, and do this more generally with default decor and not just hard coded in
to_string_pretty.See also rust-lang/cargo#11271