Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: bump distribution #386

Merged
merged 1 commit into from Dec 15, 2022
Merged

build: bump distribution #386

merged 1 commit into from Dec 15, 2022

Conversation

lucacome
Copy link
Contributor

Updates github.com/distribution/distribution/v3 from v3.0.0-20220526142353-ffbd94cbe269 to v3.0.0-20221208165359-362910506bc2

@lucacome
Copy link
Contributor Author

Fails with

Error: vendor/github.com/distribution/distribution/v3/context/http.go:35:23: undefined: strings.Cut
note: module requires Go 1.18

I guess we need #154 ?

@shizhMSFT shizhMSFT changed the title Bump distribution build: bump distribution Dec 15, 2022
@shizhMSFT
Copy link
Contributor

@lucacome I noticed that github.com/distribution/distribution/v3 has a minimum go version of 1.18. I think it is the time to bring in #154.

@lucacome @shizhMSFT
Bump distribution
54b7f34 
Signed-off-by: Luca Comellini <luca.com@gmail.com>
shizhMSFT
shizhMSFT approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit d1d3f92 into oras-project:v1 Dec 15, 2022
@FeynmanZhou FeynmanZhou added v1 Things belongs to version 1.x dependencies Pull requests that update a dependency file labels Dec 15, 2022
@moshe-kabala moshe-kabala mentioned this pull request Aug 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shizhMSFT shizhMSFT shizhMSFT approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file v1 Things belongs to version 1.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lucacome @shizhMSFT @FeynmanZhou