build: update to Go 1.18 #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is library code, adopters may still use older golang versions. We need to be careful on bumping up go versions. @jdolitsky @deitch Do you have any inputs since it is for |
lucacome
force-pushed
the
update-go-1.18-v1
branch
from
25949e2
to
be37cb9
Compare
|
Close this maybe? |
We plan to close it after releasing |
lucacome
force-pushed
the
update-go-1.18-v1
branch
2 times, most recently
from
e02ba92
to
1539f9f
Compare
I've updated the PR, but re-reading this now I'm not sure if the plan is to merge it or just close it 😅 |
Signed-off-by: Luca Comellini <luca.com@gmail.com>
shizhMSFT
force-pushed
the
update-go-1.18-v1
branch
from
1539f9f
to
87fb42a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps go to 1.18 for
v1