Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use io.ReadFull for ProviderWrapper in case of partial read #142

Merged
merged 1 commit into from May 16, 2022
Merged

use io.ReadFull for ProviderWrapper in case of partial read #142

merged 1 commit into from May 16, 2022

Conversation

raygecao
Copy link

fixes #141

@shizhMSFT shizhMSFT added the v1 Things belongs to version 1.x label May 11, 2022
@shizhMSFT
Copy link
Contributor

Thanks @raygecao for fixing the issue. The issue is for v1 implementation of oras-go. Could you change your target branch to v1 and fix DCO?

@raygecao raygecao changed the base branch from main to v1 May 11, 2022 08:19
@raygecao
not read directly in case the reader is not drained
127af01 
Signed-off-by: raygecao <raygecao@gmail.com>
shizhMSFT
shizhMSFT approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit da171cd into oras-project:v1 May 16, 2022
@shizhMSFT shizhMSFT mentioned this pull request May 16, 2022
Closed
@moshe-kabala moshe-kabala mentioned this pull request Aug 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@deitch deitch Awaiting requested review from deitch

@jdolitsky jdolitsky Awaiting requested review from jdolitsky

Assignees
No one assigned
Labels
v1 Things belongs to version 1.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ProviderWrapper can't read intact desc when the size is large
2 participants
@raygecao @shizhMSFT