Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array#pack does not support :buffer kwarg #3559

Closed
segiddins opened this issue Apr 28, 2024 · 1 comment
Closed

Array#pack does not support :buffer kwarg #3559

segiddins opened this issue Apr 28, 2024 · 1 comment
Assignees
@andrykonchin
Labels
compatibility
Milestone
24.1.0 Release (S...

Comments

@segiddins
Copy link

It has been supported since at least MRI 3.0 (https://docs.ruby-lang.org/en/3.0/Array.html#method-i-pack), and helps avoid transient string allocations when building up nested binary structures
@segiddins segiddins mentioned this issue Apr 28, 2024
Merged
@andrykonchin
Copy link
Member

Thank you for reporting the issue! Indeed, the buffer option exists for a long time (probably since Ruby 2.4).

@andrykonchin andrykonchin self-assigned this Apr 29, 2024
graalvmbot pushed a commit that referenced this issue May 7, 2024
@andrykonchin
Support buffer keyword argument to Array#pack
f163b85 
* Fixes #3559
graalvmbot pushed a commit that referenced this issue May 10, 2024
@andrykonchin
Support buffer keyword argument to Array#pack
c870d09 
* Fixes #3559
graalvmbot pushed a commit that referenced this issue May 13, 2024
@andrykonchin
Support buffer keyword argument to Array#pack
c44c87a 
* Fixes #3559
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrykonchin andrykonchin

Labels
compatibility
Projects
None yet
Milestone
24.1.0 Release (Sep 17, 2024)
Development

No branches or pull requests
2 participants
@andrykonchin @segiddins