Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is this project a code dump? only a single commit per release? #415

Open
pabs3 opened this issue Jan 9, 2022 · 1 comment
Open

is this project a code dump? only a single commit per release? #415

pabs3 opened this issue Jan 9, 2022 · 1 comment
Labels
SDK Issue pertains to the SDK itself and not specific to any service

Comments

@pabs3
Copy link

pabs3 commented Jan 9, 2022

Is this project a code dump of an internal repository?

I noticed that there is only a single commit per release, each of the commits include a ton of unrelated changes in the same commit.

The best practice with git is to make small logical changes in individual commits:

https://www.perforce.com/blog/vcs/git-best-practices-git-commit
https://gist.github.com/luismts/495d982e8c5b1a0ced4a57cf3d93cf60
https://sethrobertson.github.io/GitBestPractices/
https://community.atlassian.com/t5/Bitbucket-articles/Git-Best-Practices/ba-p/1628803
https://www.simplethread.com/what-makes-a-good-git-commit/

This helps when doing git bisects to find out which change introduced a bug.

It would be great if you could adopt git best practices.

@jodoglevy jodoglevy added the SDK Issue pertains to the SDK itself and not specific to any service label Jan 12, 2022
@pabs3
Copy link
Author

pabs3 commented May 26, 2022

Has there been any update on this? I notice a bot is now doing the releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SDK Issue pertains to the SDK itself and not specific to any service
Projects
None yet
Development

No branches or pull requests

2 participants