Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce size limit or timeout while parsing target configurations #630

Open
behnazh-w opened this issue Feb 7, 2024 · 0 comments
Open
Labels
code quality The code quality related tasks

Comments

@behnazh-w
Copy link
Member

We are parsing various kinds of untrusted source files in JSON, YAML , and bash. The JSON standard library warns about parsing JSON files and suggests putting a limit on the size of input files.

This might not be a big issue because in the worst case Macaron might hang and consume unnecessary CPU and memory. When Macaron is integrated into CI/CD or any other automated service, we could consider adding some file size limits when parsing input files.

@behnazh-w behnazh-w added the code quality The code quality related tasks label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality The code quality related tasks
Projects
None yet
Development

No branches or pull requests

1 participant