Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The description for dependencies status in the HTML is ambiguous. #538

Open
tromai opened this issue Nov 2, 2023 · 2 comments
Open

The description for dependencies status in the HTML is ambiguous. #538

tromai opened this issue Nov 2, 2023 · 2 comments
Labels
bug Something isn't working report Related to the HTML report

Comments

@tromai
Copy link
Member

tromai commented Nov 2, 2023

How to reproduce the issue

macaron analyze -rp https://github.com/apache/maven -sbom test_sbom.json

with the content of test_sbom.json as follows: test_sbom.json

image

In the example above, the dependency component org.hamcrest:hamcrest-library has the same repository URL https://github.com/hamcrest/JavaHamcrest as another dependency component org.hamcrest:hamcrest-core. Because https://github.com/hamcrest/JavaHamcrest has been analyzed already for org.hamcrest:hamcrest-core, we marked org.hamcrest:hamcrest-library as a DUPLICATED_REPO_URL component.

However, in the description column of org.hamcrest:hamcrest-library: https://github.com/hamcrest/JavaHamcrest is already analyzed.. I think this is quite confusing as the user don't know where to look for the report of that particular repository. Note that all dependencies listed in the HTML report are listed under the format of <group_id>:<name> to follow the data model.

In additions, the report column of org.hamcrest:hamcrest-library is empty (in the past, it used to link to the HTML report of org.hamcrest:hamcrest-core. However, because we are using PURL as the unique identification, I don't think linking to the same HTML report of another component with a different PURL would be a good idea.

Expect

I think we need to discuss on what would be the best way to display the "duplicated status" of dependencies. Note that after this PR is merged, the definition of "duplication" is not on the scope of repository URL, but it would be repository URL + commit or PURL with version number, etc.

@tromai tromai added bug Something isn't working report Related to the HTML report labels Nov 2, 2023
@tromai
Copy link
Member Author

tromai commented Nov 2, 2023

As discussed, we have agreed that this issue will be addressed once this PR is merged as part of the change in data model where the analysis happens on a snap shot of a repository (URL + commit) instead of only happening on the repository URL like before.

@jsoref
Copy link
Contributor

jsoref commented Jan 21, 2024

That PR was merged...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working report Related to the HTML report
Projects
None yet
Development

No branches or pull requests

2 participants