chore: use GitHub release API to filter possible tag matches #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
benmss
force-pushed
the
537-improve-commit-finder
branch
from
105ceda
to
adff5ca
Compare
|
This will be reconsidered and possibly included as part of #644 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #537
The GitHub API is called when finding commits for artefacts to retrieve release information in cases where an analysis target has a corresponding GitHub URL. These results are limited to the first 1000 instances by the API. The information retrieved includes two key properties: release name, and release tag.
The release tags retrieved via the API call can be used to filter down the list of all tags, thereby eliminating potentially spurious entries before the regular expression matching takes place. If that fails, the release names can instead be used as the list of tags for the same purpose, with the linked tag (in the API information) being returned in the case of a successful match. If that also fails, the behaviour is as it was before this change was added, i.e. all repository tags are used for the matching.