Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The check result summary can be incorrect when checks have similar requirements #522

Open
behnazh-w opened this issue Oct 19, 2023 · 0 comments
Labels
bug Something isn't working checks The issues related to Macaron checks

Comments

@behnazh-w
Copy link
Member

Over time checks with overlapping SLSA requirements are added, but the check summaries for such requirements do not reflect the consolidated results. The requirements are stored in the AnalyzeContext object, which can be overwritten by the check that runs last.

For example, both mcn_provenance_available_check and mcn_provenance_witness_level_one_1 are associated with similar SLSA requirements. If the former passes but the latter fails, the summary result is reported as failing in the console:

SLSA REQUIREMENT RESULTS:

SLSA Level 1:
- Scripted build: PASSED
- Provenance - available: FAILED
- Provenance content - identifies artifacts: FAILED
- Provenance content - identifies builder: FAILED
- Provenance content - identifies build instructions: FAILED
@behnazh-w behnazh-w added bug Something isn't working checks The issues related to Macaron checks labels Oct 19, 2023
@behnazh-w behnazh-w added this to the Support for SLSA v1.0 milestone Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working checks The issues related to Macaron checks
Projects
None yet
Development

No branches or pull requests

1 participant