Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks CI job fails with missing toml dependency #2813

Closed
xadrianzetx opened this issue Jul 17, 2021 · 1 comment
Closed

Checks CI job fails with missing toml dependency #2813

xadrianzetx opened this issue Jul 17, 2021 · 1 comment
Labels
bug Issue/PR about behavior that is broken. Not for typos/examples/CI/test but for Optuna itself.

Comments

@xadrianzetx
Copy link
Collaborator

xadrianzetx commented Jul 17, 2021

Black in latest release switched from using toml to tomli. Since toml is no longer installed in Checks workflow, blackdoc will fail the CI job.

Expected behavior

toml should be installed when CI job runs pip install --progress-bar off -U .[checking]

Environment

  • Optuna version: 2.9.0.dev0
  • Python version: Any
  • OS: Any

Error messages, stack traces, or logs

In Checks CI job

Run blackdoc . --check --diff
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.7.11/x64/bin/blackdoc", line 5, in <module>
    from blackdoc.__main__ import main
  File "/opt/hostedtoolcache/Python/3.7.11/x64/lib/python3.7/site-packages/blackdoc/__main__.py", line 12, in <module>
    from .blackcompat import (
  File "/opt/hostedtoolcache/Python/3.7.11/x64/lib/python3.7/site-packages/blackdoc/blackcompat.py", line 9, in <module>
    import toml
ModuleNotFoundError: No module named 'toml'

Example

Steps to reproduce

  1. Push the code to trigger Checks CI job
@xadrianzetx xadrianzetx added the bug Issue/PR about behavior that is broken. Not for typos/examples/CI/test but for Optuna itself. label Jul 17, 2021
@xadrianzetx
Copy link
Collaborator Author

Closing, since blackdoc added toml as dependency in latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue/PR about behavior that is broken. Not for typos/examples/CI/test but for Optuna itself.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant