Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Lix FS Interface does not support fs.readdir("...", { recursive: true }) #1850

Open
LorisSigrist opened this issue Dec 8, 2023 · 2 comments
Assignees
Labels
scope: lix Related to source-code/git-sdk. type: bug Something isn't working

Comments

@LorisSigrist
Copy link
Member

Problem

The Lix-FS Interface does not support the recursive option on readdir.

Expected behavior

fs.readdir("...", { recursive: true }) should work

Reproduction

Step 1: Try to use { recursive: true } on fs.readdir
Step 2: Get yelled at by TS

Other information

No response

@LorisSigrist LorisSigrist added the type: bug Something isn't working label Dec 8, 2023
@maige-app maige-app bot added the scope: lix Related to source-code/git-sdk. label Dec 8, 2023
@janfjohannes
Copy link
Contributor

@LorisSigrist could you add a short note on the urgency / where this is needed?

@LorisSigrist
Copy link
Member Author

In #1849 I was able to do without this, so it's no longer urgent. Right now this is a nice to have for the future.
However, whenever the need comes up to scan a directory recursively, which in the sdk might very well happen, this would be very useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: lix Related to source-code/git-sdk. type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants