Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep track of issue #13553 opened in eslint repo #10470

Closed
Hudda opened this issue Aug 28, 2020 · 5 comments
Closed

Keep track of issue #13553 opened in eslint repo #10470

Hudda opened this issue Aug 28, 2020 · 5 comments
Assignees

Comments

@Hudda
Copy link
Contributor

Hudda commented Aug 28, 2020

eslint's space-before-block is not working as expected. I've created an issue for this in the eslint repository. Keep track of that issue and make sure it is fixed.

Link to the issue: eslint/eslint#13553

@Hudda Hudda self-assigned this Aug 28, 2020
mmkm10 added a commit to mmkm10/oppia that referenced this issue Jan 8, 2021
@sajalasati
Copy link
Contributor

sajalasati commented Mar 1, 2021

Closing this issue as it has been already solved by eslint team in their PR - eslint/eslint@cbf3585. (Source: @Hudda)

@DubeySandeep
Copy link
Member

@sajalasati Do we need to update the eslint version we are using? [Feel free to close this issue if we are using the updated eslint]

@DubeySandeep DubeySandeep reopened this Mar 1, 2021
@sajalasati
Copy link
Contributor

sajalasati commented Mar 11, 2021

@Hudda Can you please verify the version of eslint (and also make changes for updating the version if needed)? Actually I am not sure where to find the current version, I looked here and acc to that I think it's 7.1.0, but the fix was included in 7.21.0 acc to the PR you told.

@Hudda
Copy link
Contributor Author

Hudda commented Apr 12, 2021

Closing this PR as updating the eslint version fixes this issue. Thanks!

@Hudda Hudda closed this as completed Apr 12, 2021
@sajalasati
Copy link
Contributor

Thanks @Hudda! I am adding the PR number here for ref - #12501.

@U8NWXD U8NWXD added this to In Progress in Developer experience Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Developer experience
  
In Progress
Development

No branches or pull requests

3 participants