Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Helm Integration] Include Catalog information with helm labels and introduce catalog filtering during Resolution #873

Open
dtfranz opened this issue May 20, 2024 · 1 comment

Comments

@dtfranz
Copy link
Contributor

dtfranz commented May 20, 2024

We should include the catalog in which the bundle was resolved from as well (and support catalog filtering during resolution). There are no guarantees that a bundle is only present/served from a single catalog on the cluster. For example, on OpenShift the Red Hat Operator Catalog and Community Operator Catalog both have some of the same entries (loki-operator is one that I found relatively quickly).

I'm fine with this being done as a follow up if we don't already have support for filtering bundles by catalog name during resolution, but if we do we should ensure we track that information as part of the labels as added by this postrenderer as well IMO.

Originally posted by @everettraven in #846 (comment)

@m1kola
Copy link
Member

m1kola commented May 21, 2024

Not sure if it has been documented somewhere, but I believe it was a deliberate UX decision. User specifies a package name and we install a package with that name which is available on the cluster. So it doesn't matter from which catalog the content is coming from. If we want to stick with this UX - then we do not need filtering by catalog name.

@joelanford might be able to add more context for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants