Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review @ControllerConfiguration options #2374

Closed
csviri opened this issue May 2, 2024 · 1 comment
Closed

Review @ControllerConfiguration options #2374

csviri opened this issue May 2, 2024 · 1 comment
Milestone

Comments

@csviri
Copy link
Collaborator

csviri commented May 2, 2024

There is a little confusion about the configurable values in the annotation, basically, now we can understand some of the values as defaults configurable with the annotation because most of them can be overridden by the configuration override. Should we just keep that ones which we know that does not make sense to override, and others should just be removed from here (and just have them as defaults in the ControllerConfiguraiton interface?

@csviri csviri added this to the 5.0 milestone May 2, 2024
@csviri
Copy link
Collaborator Author

csviri commented May 28, 2024

Was thinking of this, basically having this way set the defaults is not something very unusual. And since we plan to anyways make the annotation optional and the redesign is not straightforward (basically for any of these params, could think of a use case) would rather let this as it is, and close the issue for now.

see also: #2279

@csviri csviri closed this as completed May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant