Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve: secondaryToPrimary check type of owner reference #2371

Merged
merged 6 commits into from
May 16, 2024
Merged

improve: secondaryToPrimary check type of owner reference #2371

merged 6 commits into from
May 16, 2024

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Apr 30, 2024

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 30, 2024
@csviri csviri linked an issue Apr 30, 2024 that may be closed by this pull request
CRUDKubernetesDependentResource#delete() Deletes Non-Children Resources #2349
Closed
@csviri csviri marked this pull request as ready for review April 30, 2024 12:01
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 30, 2024
@csviri csviri requested a review from metacosm April 30, 2024 12:01
@openshift-ci openshift-ci bot requested a review from adam-sandor April 30, 2024 12:01
@csviri csviri self-assigned this Apr 30, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2024
csviri and others added 5 commits May 16, 2024 08:16
@csviri
improve: secondaryToPrimary check type of owner reference
8f1d70a 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
refactors and fixes
9af5076 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
unit tests
8f8a309 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@metacosm @csviri
refactor: minor
77c148c 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@csviri
fixes
c11c546 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 16, 2024
@csviri
fix
fb449f6 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri csviri merged commit 2ceef68 into next May 16, 2024
20 checks passed
@csviri csviri deleted the mapper-type branch May 16, 2024 07:39
csviri added a commit that referenced this pull request May 17, 2024
@csviri
improve: secondaryToPrimary check type of owner reference (#2371)
2d9a245 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request May 17, 2024
@csviri
improve: secondaryToPrimary check type of owner reference (#2371)
d91a2e5 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request May 21, 2024
@csviri
improve: secondaryToPrimary check type of owner reference (#2371)
463ee73 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metacosm metacosm metacosm approved these changes

@adam-sandor adam-sandor Awaiting requested review from adam-sandor

Assignees

@csviri csviri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CRUDKubernetesDependentResource#delete() Deletes Non-Children Resources
3 participants
@csviri @metacosm @openshift-merge-robot