Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for K8S Probes #1412

Closed
Tracked by #1422
csviri opened this issue Aug 22, 2022 · 1 comment · Fixed by #1594
Closed
Tracked by #1422

Support for K8S Probes #1412

csviri opened this issue Aug 22, 2022 · 1 comment · Fixed by #1594
Assignees
Labels
Milestone

Comments

@csviri
Copy link
Collaborator

csviri commented Aug 22, 2022

This issue is about supporting Kubernetes Probes from the framework.

The main question is how to map probes to operators in general:

  • Liveness - is operator started? (So start method called?) Is there any other meaningful way?.
    Should be this bound to sync timeout: Event Source Sync Timeout #1318 ? So if out of sync it is basically not alive?

  • Readyness (or Startup?) - probes is naturally can be bidden to event source sync, so the operator is ready when event sources are already synced.

The API:

Operator operator = new Operator()
...
operator.start()

// from this point the methods
boolean ready = operator.isReady()
boolean alive = operator.isAlive()

User later can call those methods from a servlet container or whatever integration chooses with K8S for the probes.

@csviri csviri added the feature label Aug 22, 2022
@csviri csviri added this to the 3.3 milestone Aug 22, 2022
@csviri csviri changed the title Support for Probes Support for K8S Probes Aug 22, 2022
@csviri
Copy link
Collaborator Author

csviri commented Aug 25, 2022

An other thing we should check in the probes if the informers are watching:
fabric8io/kubernetes-client#4340 (comment)

So probably the operator is not ready if the informers are not watching.

But this is related also with the issue: #1405
Where we want to start informers, and if there is not permission for the informer (and not watching) that is fine.
This however this probably requires explicit checking of permission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant