Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CatalogSource controller logging #33

Open
everettraven opened this issue Apr 12, 2023 · 1 comment
Open

Update CatalogSource controller logging #33

everettraven opened this issue Apr 12, 2023 · 1 comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. needs discussion

Comments

@everettraven
Copy link
Collaborator

We should make sure that we are logging useful information throughout the reconciliation process. The zap logger that is used has configurable levels of verbosity and we should make sure we are taking advantage of that to allow for more or less verbose log configuration.

Issue created due to #30 (comment)
@everettraven everettraven mentioned this issue Apr 12, 2023
Merged
@everettraven
Copy link
Collaborator Author

Taking a look through the controller code as of a8f7196 it looks like we still have very limited logging. It would still be nice to look into this and come up with a general consensus around what information should be logged and at what levels (could be useful for development purposes to be able to have verbose debug logs).

@everettraven everettraven added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. triage/needs-information Indicates an issue needs more information in order to work on it. needs discussion and removed triage/needs-information Indicates an issue needs more information in order to work on it. labels Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. needs discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@everettraven