Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[epic] Use encryption (HTTPS) for catalogd webserver responses #242

Open
2 of 3 tasks
joelanford opened this issue Apr 17, 2024 · 9 comments
Open
2 of 3 tasks

[epic] Use encryption (HTTPS) for catalogd webserver responses #242

joelanford opened this issue Apr 17, 2024 · 9 comments
Assignees
Labels
epic v1.0 Issues related to the initial stable release of OLMv1

Comments

@joelanford
Copy link
Member

joelanford commented Apr 17, 2024

Before we GA, catalogd's webserver needs to be updated to use encryption, for two primary reasons:

  1. In 2024, encryption is table stakes for webservers.
  2. If we ever get requirements to add authentication and authorization checks for catalogd's endpoints, encryption is required to avoid leaking client credentials in cleartext.

Adding encryption after GA would be a breaking change.

Tasks:

@joelanford joelanford added epic v1.0 Issues related to the initial stable release of OLMv1 labels Apr 17, 2024
@trgeiger
Copy link
Contributor

trgeiger commented May 1, 2024

/assign

@everettraven
Copy link
Collaborator

Existing draft PR: #243

@trgeiger I'm not sure when I'll have cycles to circle back around to ^ so feel free to spin off a new PR with that one as inspiration. I'm happy to be a point of contact and answer any questions/pair program if needed

@trgeiger
Copy link
Contributor

trgeiger commented May 2, 2024

Awesome, I was just about to ask. Thanks for getting most of the work done!

@itroyano
Copy link

itroyano commented May 3, 2024

Do we want to maintain cert files, or can we use a Serving Cert here?

@itroyano
Copy link

itroyano commented May 3, 2024

Serving certs are being handled by service-ca-operator which is an OpenShift Cluster Operator so -

  • Pros: this rotates and provides keys for us, in standard k8s secret format, so we don't have to maintain certs.
  • Cons:
    1. creates a dependency between OLM and CA Operator, so need to verify both can be alive at the same time.
    2. not applicable for upstream k8s clusters.

@everettraven
Copy link
Collaborator

@itroyano Since this is an upstream project we should use something like Cert Manager (#243 should have an example). I imagine that a vendor like OpenShift would have some logic to substitute the Cert Manager usage with something like the service-ca-operator

@trgeiger
Copy link
Contributor

trgeiger commented May 7, 2024

draft PR #263

@trgeiger
Copy link
Contributor

#263 has been merged. Next we will need to cut a release of catalogd so we can update the dependency in operator-controller and make any changes needed in operator-controller.

@trgeiger
Copy link
Contributor

Bug related to HTTPS: #270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic v1.0 Issues related to the initial stable release of OLMv1
Projects
Status: Implementing
Development

No branches or pull requests

4 participants