Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClusterServiceVersionValidator is not raising errors when the annotations are duplicated #239

Open
camilamacedo86 opened this issue Apr 27, 2022 · 3 comments

Comments

@camilamacedo86
Copy link
Contributor

Description
ClusterServiceVersionValidator is not raising errors when the annotations are duplicated
The e.g scenario can be found in: https://github.com/redhat-openshift-ecosystem/community-operators-prod/pull/1121/files#diff-c0ad3966e15bf1757f16f02b664a3093ebf00f0e74956753ee48de223996268c

See that community is calling the bundle to validate and it does not fail when the CSV defined the annotations twice:

apiVersion: operators.coreos.com/v1alpha1
kind: ClusterServiceVersion
metadata:
  annotations:
    alm-examples: '[]'
    capabilities: Basic Install
    categories: Application Runtime, Monitoring, Security
    certified: "false"
    containerImage: quay.io/deployment-validation-operator/dv-operator:0.2.2
    createdAt: 12/14/2021
    description: The deployment validation operator
    repository: https://github.com/app-sre/deployment-validation-operator
    support: Best Effort
  name: deployment-validation-operator.v0.2.2
  annotations:
    ignore-check.kube-linter.io/minimum-three-replicas: "This deployment uses 1 pod as currently replicating does not replicate metric data causing installation issues"
spec:

@camilamacedo86
Copy link
Contributor Author

@ryantking this issue was reported by the Community CVP and we need to check this scenario to fix it on the checks.
c/c @mvalarh @jozzi

@J0zi
Copy link

J0zi commented Apr 27, 2022

I suppose sdk should check if yaml is valid and also if csv is valid so can be correctly displayed in catalog

@camilamacedo86
Copy link
Contributor Author

@ryantking do you think that you could give us a hand with this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants