From bb24ffece53135806188c30cdda9182c6edbe0e4 Mon Sep 17 00:00:00 2001 From: Adrien Joly <531781+adrienjoly@users.noreply.github.com> Date: Tue, 27 Dec 2022 12:07:33 +0100 Subject: [PATCH] get rid of `browniebroke/read-nvmrc-action`, since `actions/setup-node` can read node version from `.nvmrc` file directly cf https://github.com/actions/setup-node/issues/32#issuecomment-1003854758 --- .github/workflows/ci.yml | 32 ++++++++------------------------ 1 file changed, 8 insertions(+), 24 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 345cc5ada..63740c160 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -19,11 +19,9 @@ jobs: runs-on: ubuntu-20.04 steps: - uses: actions/checkout@v3 - - uses: browniebroke/read-nvmrc-action@v1 # Read node version from `.nvmrc` file - id: nvmrc - uses: actions/setup-node@v3 with: - node-version: '${{ steps.nvmrc.outputs.node_version }}' + node-version-file: '.nvmrc' cache: 'npm' - name: npm install env: @@ -69,11 +67,9 @@ jobs: - 27017:27017 steps: - uses: actions/checkout@v3 - - uses: browniebroke/read-nvmrc-action@v1 # Read node version from `.nvmrc` file - id: nvmrc - uses: actions/setup-node@v3 with: - node-version: '${{ steps.nvmrc.outputs.node_version }}' + node-version-file: '.nvmrc' cache: 'npm' - uses: c-py/action-dotenv-to-setenv@v2 with: @@ -128,11 +124,9 @@ jobs: - 27117:27017 steps: - uses: actions/checkout@v3 - - uses: browniebroke/read-nvmrc-action@v1 # Read node version from `.nvmrc` file - id: nvmrc - uses: actions/setup-node@v3 with: - node-version: '${{ steps.nvmrc.outputs.node_version }}' + node-version-file: '.nvmrc' cache: 'npm' - uses: c-py/action-dotenv-to-setenv@v2 with: @@ -151,11 +145,9 @@ jobs: runs-on: ubuntu-20.04 steps: - uses: actions/checkout@v3 - - uses: browniebroke/read-nvmrc-action@v1 # Read node version from `.nvmrc` file - id: nvmrc - uses: actions/setup-node@v3 with: - node-version: '${{ steps.nvmrc.outputs.node_version }}' + node-version-file: '.nvmrc' cache: 'npm' - name: npm install env: @@ -173,11 +165,9 @@ jobs: runs-on: ubuntu-20.04 steps: - uses: actions/checkout@v3 - - uses: browniebroke/read-nvmrc-action@v1 # Read node version from `.nvmrc` file - id: nvmrc - uses: actions/setup-node@v3 with: - node-version: '${{ steps.nvmrc.outputs.node_version }}' + node-version-file: '.nvmrc' cache: 'npm' - name: npm install env: @@ -200,11 +190,9 @@ jobs: - 27017:27017 steps: - uses: actions/checkout@v3 - - uses: browniebroke/read-nvmrc-action@v1 # Read node version from `.nvmrc` file - id: nvmrc - uses: actions/setup-node@v3 with: - node-version: '${{ steps.nvmrc.outputs.node_version }}' + node-version-file: '.nvmrc' cache: 'npm' - uses: c-py/action-dotenv-to-setenv@v2 with: @@ -238,11 +226,9 @@ jobs: - 27117:27017 steps: - uses: actions/checkout@v3 - - uses: browniebroke/read-nvmrc-action@v1 # Read node version from `.nvmrc` file - id: nvmrc - uses: actions/setup-node@v3 with: - node-version: '${{ steps.nvmrc.outputs.node_version }}' + node-version-file: '.nvmrc' cache: 'npm' - uses: c-py/action-dotenv-to-setenv@v2 with: @@ -387,11 +373,9 @@ jobs: with: # to prevent "You're not authorized to push to this branch" persist-credentials: false - - uses: browniebroke/read-nvmrc-action@v1 # Read node version from `.nvmrc` file - id: nvmrc - uses: actions/setup-node@v3 with: - node-version: '${{ steps.nvmrc.outputs.node_version }}' + node-version-file: '.nvmrc' cache: 'npm' - run: npm install --prefer-offline --no-audit if: github.event_name == 'push'