Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic Conventions has broken link to the spec #349

Open
jpkrohling opened this issue Oct 19, 2018 · 3 comments
Open

Semantic Conventions has broken link to the spec #349

jpkrohling opened this issue Oct 19, 2018 · 3 comments

Comments

@jpkrohling
Copy link
Contributor

jpkrohling commented Oct 19, 2018

The first link on the contents of the Semantic Conventions page has a broken link to the specification. It currently links to https://opentracing.io/specification/conventions/specification.md , but should be https://opentracing.io/specification/

image

@austinlparker
Copy link
Member

Yeah, that's a tricky one to fix because all of the files in the specification section are actually coming in via a submodule of the Specification repo itself. Since the files are the ones from the spec repo, all of the links are relative to that repository rather than the website. I'm not sure the best way to fix it to be honest; We could scrap the submodule and just manually update the website spec when the real spec changes, or we could try to come up with something clever.

@jpkrohling
Copy link
Contributor Author

Yeah, that's a tricky one to fix

That's why I didn't open a PR right away 😄

@jan25
Copy link

jan25 commented Jun 8, 2019

There are more links in opentracing.io with similar problem that directly point to .md files in specification repo. Not sure if Hugo has some feature to handle such scenarios, where we specify how to handle a specific route for example <a> tag with specificiation.md would instead route to to /specification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants