From 993aa1d0ea14f6274137f8319ac8a5d01c4839ea Mon Sep 17 00:00:00 2001 From: Rahman Syed Date: Sun, 18 Feb 2018 22:57:12 -0600 Subject: [PATCH] OpenTracing Semantic Conventions uses error.object The OpenTracing Specification suggests "error.object" as the log key for an error object. Fixes #164 --- log/field.go | 4 ++-- log/field_test.go | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/log/field.go b/log/field.go index 50feea3..8a85140 100644 --- a/log/field.go +++ b/log/field.go @@ -122,10 +122,10 @@ func Float64(key string, val float64) Field { } } -// Error adds an error with the key "error" to a Span.LogFields() record +// Error adds an error with the key "error.object" to a Span.LogFields() record func Error(err error) Field { return Field{ - key: "error", + key: "error.object", fieldType: errorType, interfaceVal: err, } diff --git a/log/field_test.go b/log/field_test.go index 73ab172..a635b1b 100644 --- a/log/field_test.go +++ b/log/field_test.go @@ -24,11 +24,11 @@ func TestFieldString(t *testing.T) { }, { field: Error(fmt.Errorf("err msg")), - expected: "error:err msg", + expected: "error.object:err msg", }, { field: Error(nil), - expected: "error:", + expected: "error.object:", }, { field: Noop(),