This repository has been archived by the owner on May 23, 2023. It is now read-only.
Set nil pointer to string nil when converting key values. #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes a panic that will be recovered by the fmt package. Altought on darwin this makes any project using open tracing impossible to debug. see cortexproject/cortex#1712 Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
|
please add a test |
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
|
This function wasn't covered by any tests, unless I'm mistaken, anyways I added a test to cover it entirely. |
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
=========================================
Coverage ? 68.71%
=========================================
Files ? 15
Lines ? 847
Branches ? 0
=========================================
Hits ? 582
Misses ? 225
Partials ? 40
Continue to review full report at Codecov.
|
yurishkuro
reviewed
Jan 23, 2020
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| var nilInterface io.Reader |
There was a problem hiding this comment.
this can be scoped inside the test function
yurishkuro
approved these changes
Jan 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes a panic that will be recovered by the fmt package.
Althought on darwin this makes any projects using open tracing impossible to debug with dlv
see cortexproject/cortex#1712
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com