Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

Change SetTag helpers in ext to public #228

Closed
blakewedwards opened this issue Dec 4, 2019 · 2 comments
Closed

Change SetTag helpers in ext to public #228

blakewedwards opened this issue Dec 4, 2019 · 2 comments

Comments

@blakewedwards
Copy link
Contributor

type stringTagName string

Would it be accepted to make the SetTag helpers like stringTagName public so that users of the package can make their own reusable taggers?

Proposal

ext.stringTagName -> ext.StringTagName
ext.uint16TagName -> ext.Uint16TagName
etc.

@yurishkuro
Copy link
Member

I think it'd make sense. The current private types are a bit weird - we return private type, but expect users to use a public method on it. And those methods don't show in godocs

https://godoc.org/github.com/opentracing/opentracing-go/ext

@blakewedwards
Copy link
Contributor Author

#229

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants