Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

Update noop.go #223

Merged
merged 2 commits into from Sep 13, 2019
Merged

Update noop.go #223

merged 2 commits into from Sep 13, 2019

Conversation

chanxuehong
Copy link
Contributor

@chanxuehong chanxuehong commented Sep 13, 2019

as SetTag, SetOperationName
i think there should be

return n

rather than

return defaultNoopSpan

Specify type to avoid type conversion when return these values as interface

	defaultNoopSpanContext SpanContext = noopSpanContext{}
	defaultNoopSpan        Span        = noopSpan{}
	defaultNoopTracer      Tracer      = NoopTracer{}

@codecov-io
Copy link

codecov-io commented Sep 13, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@16ba2b6). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #223   +/-   ##
=========================================
  Coverage          ?   59.54%           
=========================================
  Files             ?       14           
  Lines             ?      833           
  Branches          ?        0           
=========================================
  Hits              ?      496           
  Misses            ?      297           
  Partials          ?       40
Impacted Files Coverage Δ
noop.go 5% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16ba2b6...8f91b8f. Read the comment docs.

@yurishkuro yurishkuro merged commit a7454ce into opentracing:master Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants