Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

error.object or just error? #164

Closed
kr opened this issue Oct 20, 2017 · 2 comments · Fixed by #179
Closed

error.object or just error? #164

kr opened this issue Oct 20, 2017 · 2 comments · Fixed by #179

Comments

@kr
Copy link

kr commented Oct 20, 2017

https://github.com/opentracing/specification/blob/master/semantic_conventions.md says to use "error.object" as the log key for an error object, but

opentracing-go/log/field.go

Lines 126 to 132 in 1361b9c

func Error(err error) Field {
return Field{
key: "error",
fieldType: errorType,
interfaceVal: err,
}
}
uses "error". Which is right?

@yurishkuro
Copy link
Member

I think error.object would've been the right name in opentracing-go/log/field.go

rahmansyed pushed a commit to rahmansyed/opentracing-go that referenced this issue Feb 19, 2018
The OpenTracing Specification suggests "error.object" as the log
key for an error object.

Fixes opentracing#164
@miry
Copy link

miry commented Apr 8, 2020

@yurishkuro Is any reason to not merge #179 to fix this issue ?

yurishkuro pushed a commit that referenced this issue Apr 8, 2020
The OpenTracing Specification suggests "error.object" as the log
key for an error object.

Fixes #164

Co-authored-by: Rahman Syed <rahman.syed@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants