Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address post-merge Docker Compose cleanup issues #3081

Closed
1 of 6 tasks
migurski opened this issue Feb 3, 2021 · 4 comments · Fixed by #3083
Closed
1 of 6 tasks

Address post-merge Docker Compose cleanup issues #3081

migurski opened this issue Feb 3, 2021 · 4 comments · Fixed by #3083
Labels
dx Developer Experience refactor Refactoring, or things that work but could be done better

Comments

@migurski
Copy link
Contributor

migurski commented Feb 3, 2021

Tom H identifies a few desired changes in #2409 (review):

  • Investigate alternative to Postgres sleep
  • Update checkout to v2
  • Investigate bootsnap-related pollution in Rails setup files
  • Move DB functions to either lib or share
  • Determine if a DB password is needed when using trust auth
  • Investigate whether yarnpkg install can move under bundle exec

I’ll look at each of these in a follow up PR and determine which needs a followup change vs. just an explanation.

@tomhughes
Copy link
Member

The good news is that it all seems to work using podman-compose in place of docker-compose in Fedora 33.

@tuckerrc tuckerrc added refactor Refactoring, or things that work but could be done better dx Developer Experience labels Feb 3, 2021
@mmd-osm
Copy link
Contributor

mmd-osm commented Feb 4, 2021

Re " Move DB functions to either lib or share" : /changes endpoint was removed yesterday, we don't need those DB functions anymore.

@tomhughes
Copy link
Member

Also #3082 has bumped the checkout action version.

@gravitystorm
Copy link
Collaborator

Re " Move DB functions to either lib or share" : /changes endpoint was removed yesterday, we don't need those DB functions anymore.

I know you'll have seen my comment, but just for other people's reference, we still need the function for the migrations: #2409 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Developer Experience refactor Refactoring, or things that work but could be done better
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants