Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vagrant and Docker installations are unmaintained #2344

Open
tomhughes opened this issue Aug 7, 2019 · 7 comments
Open

Vagrant and Docker installations are unmaintained #2344

tomhughes opened this issue Aug 7, 2019 · 7 comments
Labels
dx Developer Experience meta Related to this repository or workflows

Comments

@tomhughes
Copy link
Member

tomhughes commented Aug 7, 2019

Bother vagrant and docker installations suffer from constant bitrot where we add new dependencies or change configuration files but don't update the relevant setup scripts.

Unfortunately we have no way of detecting this until some unfortunate end user tries to use them because none of the main developers uses them.

We either need to find a way of testing them (is that even possible in travis? or is there some other way?) or we need to admit defeat and remove them.

@tomhughes tomhughes changed the title Vagrant and Docker installtions are unmaintained Vagrant and Docker installations are unmaintained Aug 7, 2019
@tomhughes
Copy link
Member Author

So vagrant can't be done in travis apparently (travis-ci/travis-ci#6060) so we can forget that at least.

@openbrian
Copy link
Contributor

I'd prefer to develop in a docker environment. I can work on creating a new Dockerfile. Do you have any requirements? My plan is to create 2 images, one for db and one for rails. For me this may have to wait until after SotM US.

@mmd-osm
Copy link
Contributor

mmd-osm commented Aug 26, 2019

@openbrian : see #2272

@tomhughes
Copy link
Member Author

Yes this ticket is probably a bit confusing because I opened it thinking we already had a docker config but apparently my memory was faulty... Though it's definitely true that it would be good to have it tested to stop it breaking. That's something that I think travis can do, unlike vagrant.

@gravitystorm
Copy link
Collaborator

So I don't think we really need the vagrant/virtualbox bit tested, so much as the rest of the setup script i.e the contents of /script/vagrant/setup/provision.sh. Could that be tested on travis?

Of course, both the travis config and the vagrant setup (and the Docker setup) cover a lot of the same ground - installing postgres, bundle install, etc. So if there's a way to refactor things to share some code, that would be great too.

@fazlerabbi37
Copy link
Contributor

just find this page where is seems docker builds can be tested with travis. Though needs to take a closer look at this.


I'd prefer to develop in a docker environment. I can work on creating a new Dockerfile. Do you have any requirements? My plan is to create 2 images, one for db and one for rails. For me this may have to wait until after SotM US.

@openbrian please give your feedback on #2272 as I am just a novice on docker. 😊

@jalessio
Copy link
Contributor

For reference, just adding a note here that I'm attempting to address the Docker part of this in PR #2409

@tuckerrc tuckerrc added dx Developer Experience meta Related to this repository or workflows labels Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Developer Experience meta Related to this repository or workflows
Projects
None yet
Development

No branches or pull requests

7 participants