Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are you intrested in a new test runner? #8686

Closed
wvanderp opened this issue Sep 10, 2021 · 2 comments
Closed

Are you intrested in a new test runner? #8686

wvanderp opened this issue Sep 10, 2021 · 2 comments

Comments

@wvanderp
Copy link
Contributor

Hello,

Are you interested in a replacement for the phantomjs test runner? I can change it over to karma.

A long story long: I found a bug that I still need to report. But I thought I could also try to fix it myself and make a pull request. During my quest in TTD, I tried to run the test and found it underwhelming.

So, I started working on a replacement, and karma is a good fit here. It can also use phantomjs but also can use chrome and firefox. It also produces test coverage, uses mocha and chai, and is easy to debug.

I made a proof of concept which will run most of the tests, and for 20 or so tests, I need to see what is wrong.

I just wanted to know if you are interested in this change before I put more time into it. And if you have any wishes for the test runner, just let me know.

@jfirebaugh
Copy link
Member

Hi @wvanderp, this sounds quite promising to me! As you may be aware, we have a long standing issue to replace PhantomJS: #7697. Karma does seem like the most viable replacement. I assume we would use Headless Chromium with Puppeteer as the default test browser.

@jfirebaugh
Copy link
Member

Switched to Karma in #8764. Thanks @wvanderp!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants