From edb17812be0645779a62580f6ce55539616aaf78 Mon Sep 17 00:00:00 2001 From: Colin Walters Date: Fri, 17 Dec 2021 13:51:33 -0500 Subject: [PATCH] upload-ami: Extend blurb about how things should go into coreos-assembler Motivated by recent Aliyun additions; adding stuff like that here makes it harder to do Aliyun stuff with FCOS *and* breaks the model that this repo is the definition of the OS, not the pipeline to build the OS. --- scripts/upload-ami | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/scripts/upload-ami b/scripts/upload-ami index 43ca0e32..3dd14f79 100755 --- a/scripts/upload-ami +++ b/scripts/upload-ami @@ -1,8 +1,13 @@ #!/usr/bin/python3 -u -# Wraps coreos-assembler buildextend-aws which itself wraps `ore aws upload`, +# THIS SCRIPT SHOULD BE CONSIDERED DEPRECATED; please avoid extending it! +# Instead, add new functionality into coreos-assembler. +# +# This wraps coreos-assembler buildextend-aws which itself wraps `ore aws upload`, # but also supports making the images public because ore doesn't do that right -# now. Eventually we may use plume? +# now. For FCOS, that's handled via plume, but RHCOS as of right now doesn't +# use that. But, what would make sense here is to move some of this functionality +# into cosa buildextend-aws, such as the marketplace support. import argparse import json