Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

denylist: add crio.base #677

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

miabbott
Copy link
Member

This is failing on all arches right now and no resolution in sight;
let's skip this test for now.

See: #674

This is failing on all arches right now and no resolution in sight;
let's skip this test for now.

See: openshift#674
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2021
@cgwalters
Copy link
Member

The interesting thing here is whether this crio works in OpenShift right? Do we know the answer to that yet?

But it is true that some of these failures in the past have been specific to our hacked-up "stand up crio outside of openshift" bits.

Since upstream crio is gating on OpenShift tests and we have e2e gating on both the installer and promote job we could perhaps just drop our crio testing and rely on that. So...

/lgtm
/override ci/prow/build-test-qemu

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 17, 2021

@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/build-test-qemu

In response to this:

The interesting thing here is whether this crio works in OpenShift right? Do we know the answer to that yet?

But it is true that some of these failures in the past have been specific to our hacked-up "stand up crio outside of openshift" bits.

Since upstream crio is gating on OpenShift tests and we have e2e gating on both the installer and promote job we could perhaps just drop our crio testing and rely on that. So...

/lgtm
/override ci/prow/build-test-qemu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, miabbott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 39252a6 into openshift:master Nov 17, 2021
@miabbott
Copy link
Member Author

The interesting thing here is whether this crio works in OpenShift right? Do we know the answer to that yet?

But it is true that some of these failures in the past have been specific to our hacked-up "stand up crio outside of openshift" bits.

Since upstream crio is gating on OpenShift tests and we have e2e gating on both the installer and promote job we could perhaps just drop our crio testing and rely on that. So...

/lgtm /override ci/prow/build-test-qemu

Thanks for the override. This will at least unblock builds and get newer versions of crio/kubelet to folks who need them.

I'm like 87% in favor of dropping our crio tests, but the few times we have failed did highlght a regression (or at least change in defaults) in crio behavior. Though the main use case of crio in OCP has continued to be successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants