Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest: pull runc from the OCP repo #652

Merged
merged 1 commit into from Nov 1, 2021

Conversation

miabbott
Copy link
Member

The current version of runc getting pulled into RHCOS is an older
version coming from the rhel-8-appstream repo. We want to start
using correctly versioned packages from the container-tools stack
and this is the first step.

See: https://bugzilla.redhat.com/show_bug.cgi?id=2013822

@miabbott
Copy link
Member Author

After this change:

Upgraded:                                                                                                                                                                                                                                                                                                                     
  runc 1.0.0-74.rc95.module+el8.4.0+11822+6cc1e7d7 -> 1.0.0-98.rhaos4.8.gitcd80260.el8

Still need to sort out with Node/Containers team about getting the right rhaos4.10 version of the package in the plashet.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2021
Copy link
Contributor

@saqibali-2k saqibali-2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@miabbott
Copy link
Member Author

miabbott commented Oct 14, 2021

Oct 14 14:00:40 qemu0 kola-runext-misc-ro.sh[1606]: + [[ -n runc-1.0.0-98.rhaos4.8.gitcd80260.el8.x86_64 ]]
Oct 14 14:00:40 qemu0 kola-runext-misc-ro.sh[1606]: + fatal 'Error: rhaos packages do not match OpenShift version'

As expected....I guess I should put this PR on hold until we get that sorted out.

@miabbott miabbott marked this pull request as draft October 14, 2021 15:06
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2021
The current version of `runc` getting pulled into RHCOS is an older
version coming from the `rhel-8-appstream` repo. We want to start
using correctly versioned packages from the `container-tools` stack
and this is the first step.

See: https://bugzilla.redhat.com/show_bug.cgi?id=2013822
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2021
@miabbott miabbott marked this pull request as ready for review November 1, 2021 20:36
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2021
@miabbott
Copy link
Member Author

miabbott commented Nov 1, 2021

The OSE repo has an up-to-date version of runc available, so the CI jobs should start passing again.

Side-effect of this change is that we get crun pulled in as well (as desired by the Container Tools team).

@cgwalters
Copy link
Member

/lgtm
But it still really seems to me that forking the container module by default for OCP is a long term bad strategy.
I mean, it already has to be a large burden on the container team to have multiple (traditional) RHEL streams for !OCP cases, on top of an OCP version. I guess the flip side is we don't actually really use podman except for bootstrapping, just runc.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, miabbott, saqibali-2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cgwalters,miabbott,saqibali-2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 237a907 into openshift:master Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants