-
Notifications
You must be signed in to change notification settings - Fork 59
/
private.go
530 lines (480 loc) · 18.2 KB
/
private.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
package gcp
// "Private" or non-interface conforming methods
import (
"bytes"
"context"
"fmt"
"net/http"
"reflect"
"google.golang.org/api/compute/v1"
gdnsv1 "google.golang.org/api/dns/v1"
"google.golang.org/api/googleapi"
configv1 "github.com/openshift/api/config/v1"
cloudingressv1alpha1 "github.com/openshift/cloud-ingress-operator/pkg/apis/cloudingress/v1alpha1"
gcpproviderapi "github.com/openshift/cluster-api-provider-gcp/pkg/apis/gcpprovider/v1beta1"
machineapi "github.com/openshift/machine-api-operator/pkg/apis/machine/v1beta1"
corev1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/apimachinery/pkg/runtime/serializer"
"k8s.io/apimachinery/pkg/types"
"sigs.k8s.io/controller-runtime/pkg/client"
cioerrors "github.com/openshift/cloud-ingress-operator/pkg/errors"
baseutils "github.com/openshift/cloud-ingress-operator/pkg/utils"
)
// ensureAdminAPIDNS ensures the DNS record for the "admin API" Service
// LoadBalancer is accurately set
func (c *Client) ensureAdminAPIDNS(ctx context.Context, kclient client.Client, instance *cloudingressv1alpha1.APIScheme, svc *corev1.Service) error {
return c.ensureDNSForService(kclient, svc, instance.Spec.ManagementAPIServerIngress.DNSName)
}
// deleteAdminAPIDNS ensures the DNS record for the "admin API" Service
// LoadBalancer is deleted
func (c *Client) deleteAdminAPIDNS(ctx context.Context, kclient client.Client, instance *cloudingressv1alpha1.APIScheme, svc *corev1.Service) error {
return c.removeDNSForService(kclient, svc, instance.Spec.ManagementAPIServerIngress.DNSName)
}
// ensureSSHDNS ensures the DNS record for the SSH Service LoadBalancer
// is accurately set
func (c *Client) ensureSSHDNS(ctx context.Context, kclient client.Client, instance *cloudingressv1alpha1.SSHD, svc *corev1.Service) error {
return c.ensureDNSForService(kclient, svc, instance.Spec.DNSName)
}
// deleteSSHDNS ensures the DNS record for the SSH Service LoadBalancer
// is deleted
func (c *Client) deleteSSHDNS(ctx context.Context, kclient client.Client, instance *cloudingressv1alpha1.SSHD, svc *corev1.Service) error {
return c.removeDNSForService(kclient, svc, instance.Spec.DNSName)
}
// setDefaultAPIPrivate sets the default api (api.<cluster-domain>) to private
// scope
func (c *Client) setDefaultAPIPrivate(ctx context.Context, kclient client.Client, _ *cloudingressv1alpha1.PublishingStrategy) error {
intIPAddress, err := c.removeLoadBalancerFromMasterNodes(ctx, kclient)
if err != nil {
return fmt.Errorf("Failed to remove load balancer from master nodes: %v", err)
}
baseDomain, err := baseutils.GetClusterBaseDomain(kclient)
if err != nil {
return err
}
apiDNSName := fmt.Sprintf("api.%s.", baseDomain)
oldIP, err := c.updateAPIARecord(kclient, apiDNSName, intIPAddress)
if err != nil {
return err
}
// If the IP wasn't updated, there is nothing else to do
if oldIP == intIPAddress {
return nil
}
region, err := getClusterRegion(kclient)
if err != nil {
return err
}
infrastructureName, err := baseutils.GetClusterName(kclient)
if err != nil {
return err
}
staticIPName := infrastructureName + "-cluster-public-ip"
err = c.releaseExternalIP(region, staticIPName)
if err != nil {
return err
}
log.Info("Succcessfully set default API to private", "URL", apiDNSName, "IP Address", intIPAddress)
return nil
}
// setDefaultAPIPublic sets the default API (api.<cluster-domain>) to public
// scope
func (c *Client) setDefaultAPIPublic(ctx context.Context, kclient client.Client, instance *cloudingressv1alpha1.PublishingStrategy) error {
region, err := getClusterRegion(kclient)
if err != nil {
return err
}
listCall := c.computeService.ForwardingRules.List(c.projectID, region)
response, err := listCall.Do()
if err != nil {
return err
}
// Create a new external LB
infrastructureName, err := baseutils.GetClusterName(kclient)
if err != nil {
return err
}
//GCP ForwardingRule and TargetPool share the same name
extNLBName := infrastructureName + "-api"
staticIPName := infrastructureName + "-cluster-public-ip"
for _, lb := range response.Items {
// This list of forwardingrules (LBs) includes any service LBs
// for application routers so check the port range to identify
// the external API LB.
if lb.LoadBalancingScheme == "EXTERNAL" && lb.PortRange == "6443-6443" && lb.Name == extNLBName {
// If there is already an external LB serving over the API port, there is nothing to do.
return nil
}
}
staticIPAddress, err := c.createExternalIP(staticIPName, "EXTERNAL", region)
if err != nil {
return err
}
err = c.createNetworkLoadBalancer(extNLBName, "EXTERNAL", extNLBName, region, staticIPAddress)
if err != nil {
return err
}
baseDomain, err := baseutils.GetClusterBaseDomain(kclient)
if err != nil {
return err
}
apiDNSName := fmt.Sprintf("api.%s.", baseDomain)
_, err = c.updateAPIARecord(kclient, apiDNSName, staticIPAddress)
if err != nil {
return err
}
log.Info("Successfully set default API load balancer to external", "URL", apiDNSName, "IP address", staticIPAddress)
return nil
}
func (c *Client) ensureDNSForService(kclient client.Client, svc *corev1.Service, dnsName string) error {
// google.golang.org/api/dns/v1.Service is a struct, not an interface, which
// will make this all but impossible to write unit tests for
svcIPs, err := getIPAddressesFromService(svc)
if err != nil {
return err
}
baseDomain, err := baseutils.GetClusterBaseDomain(kclient)
if err != nil {
return err
}
FQDN := dnsName + "." + baseDomain + "."
// The resource record set to add.
// Kind and SignatureRrdatas are set as
// they are to satisfy reflect.DeepEqual.
newRRSet := &gdnsv1.ResourceRecordSet{
Kind: "dns#resourceRecordSet",
Name: FQDN,
Rrdatas: svcIPs,
SignatureRrdatas: []string{},
Type: "A",
Ttl: 30,
}
clusterDNS := &configv1.DNS{}
err = kclient.Get(context.TODO(), types.NamespacedName{Name: "cluster"}, clusterDNS)
if err != nil {
return err
}
var zones []configv1.DNSZone
if clusterDNS.Spec.PublicZone != nil {
zones = append(zones, *clusterDNS.Spec.PublicZone)
}
if clusterDNS.Spec.PrivateZone != nil {
zones = append(zones, *clusterDNS.Spec.PrivateZone)
}
for _, zone := range zones {
dnsChange := &gdnsv1.Change{
Additions: []*gdnsv1.ResourceRecordSet{newRRSet},
}
// Look for an existing resource record set in the zone.
listCall := c.dnsService.ResourceRecordSets.List(c.projectID, zone.ID)
response, err := listCall.Name(FQDN).Do()
if err != nil {
return err
}
// There will be at most one result but loop anyway.
// An empty slice will proceed directly to Create.
for _, rrset := range response.Rrsets {
if reflect.DeepEqual(newRRSet, rrset) {
dnsChange.Additions = []*gdnsv1.ResourceRecordSet{}
} else {
dnsChange.Deletions = append(dnsChange.Deletions, rrset)
}
}
if len(dnsChange.Additions) > 0 {
log.Info("Submitting DNS changes:", "Zone", zone.ID,
"Additions", dnsChange.Additions, "Deletions", dnsChange.Deletions)
changesCall := c.dnsService.Changes.Create(c.projectID, zone.ID, dnsChange)
_, err = changesCall.Do()
if err != nil {
return err
}
}
}
return nil
}
func (c *Client) removeDNSForService(kclient client.Client, svc *corev1.Service, dnsName string) error {
// google.golang.org/api/dns/v1.Service is a struct, not an interface, which
// will make this all but impossible to write unit tests for
baseDomain, err := baseutils.GetClusterBaseDomain(kclient)
if err != nil {
return err
}
FQDN := dnsName + "." + baseDomain + "."
clusterDNS := &configv1.DNS{}
err = kclient.Get(context.TODO(), types.NamespacedName{Name: "cluster"}, clusterDNS)
if err != nil {
return err
}
var zones []configv1.DNSZone
if clusterDNS.Spec.PublicZone != nil {
zones = append(zones, *clusterDNS.Spec.PublicZone)
}
if clusterDNS.Spec.PrivateZone != nil {
zones = append(zones, *clusterDNS.Spec.PrivateZone)
}
for _, zone := range zones {
dnsChange := &gdnsv1.Change{}
// Look for an existing resource record set in the zone.
listCall := c.dnsService.ResourceRecordSets.List(c.projectID, zone.ID)
response, err := listCall.Name(FQDN).Do()
if err != nil {
return err
}
// There will be at most one result but append anyway.
dnsChange.Deletions = append(dnsChange.Deletions, response.Rrsets...)
if len(dnsChange.Deletions) > 0 {
log.Info("Submitting DNS changes:", "Zone", zone.ID, "Deletions", dnsChange.Deletions)
call := c.dnsService.Changes.Create(c.projectID, zone.ID, dnsChange)
_, err = call.Do()
if err != nil {
dnsError, ok := err.(*googleapi.Error)
if !ok || dnsError.Code != http.StatusNotFound {
return err
}
}
}
}
return nil
}
func getIPAddressesFromService(svc *corev1.Service) ([]string, error) {
var ips []string
for _, ingress := range svc.Status.LoadBalancer.Ingress {
ips = append(ips, ingress.IP)
}
if len(ips) == 0 {
return nil, cioerrors.NewLoadBalancerNotReadyError()
}
return ips, nil
}
func (c *Client) removeLoadBalancerFromMasterNodes(ctx context.Context, kclient client.Client) (string, error) {
region, err := getClusterRegion(kclient)
if err != nil {
return "", err
}
listCall := c.computeService.ForwardingRules.List(c.projectID, region)
response, err := listCall.Do()
if err != nil {
return "", err
}
masterList, err := baseutils.GetMasterMachines(kclient)
if err != nil {
return "", err
}
infrastructureName, err := baseutils.GetClusterName(kclient)
if err != nil {
return "", err
}
extNLBName := infrastructureName + "-api"
intLBName := infrastructureName + "-api-internal"
var intIPAddress, lbName string
for _, lb := range response.Items {
// This list of forwardingrules (LBs) includes any service LBs
// for application routers so check the port range and name to identify
// the external API LB.
if lb.LoadBalancingScheme == "EXTERNAL" && lb.PortRange == "6443-6443" && lb.Name == extNLBName {
//delete the LB and remove it from the masters
lbName = lb.Name
_, err := c.computeService.ForwardingRules.Delete(c.projectID, region, lbName).Do()
if err != nil {
return "", fmt.Errorf("Failed to delete ForwardingRule for external load balancer %v: %v", lb.Name, err)
}
err = removeGCPLBFromMasterMachines(kclient, lbName, masterList)
if err != nil {
return "", err
}
}
// we need this to update DNS
if lb.LoadBalancingScheme == "INTERNAL" && lb.BackendService != "" && lb.Name == intLBName {
// Unlike AWS, GCP NLBs don't have automatically assigned A records, just an external IP address
// Save the internal NLB's IP Address in order to update the API's A record in the public DNS zone.
intIPAddress = lb.IPAddress
}
}
return intIPAddress, nil
}
func getClusterRegion(kclient client.Client) (string, error) {
infra, err := baseutils.GetInfrastructureObject(kclient)
if err != nil {
return "", err
}
return infra.Status.PlatformStatus.GCP.Region, nil
}
func removeGCPLBFromMasterMachines(kclient client.Client, lbName string, masterNodes *machineapi.MachineList) error {
for _, machine := range masterNodes.Items {
providerSpecDecoded, err := getGCPDecodedProviderSpec(machine)
if err != nil {
log.Error(err, "Error retrieving decoded ProviderSpec for machine", "machine", machine.Name)
return err
}
lbList := providerSpecDecoded.TargetPools
newLBList := []string{}
for _, lb := range lbList {
if lb != lbName {
log.Info("Machine's LB does not match LB to remove", "Machine LB", lb, "LB to remove", lbName)
log.Info("Keeping machine's LB in machine object", "LB", lb, "Machine", machine.Name)
newLBList = append(newLBList, lb)
}
}
err = updateGCPLBList(kclient, lbList, newLBList, machine, providerSpecDecoded)
if err != nil {
log.Error(err, "Error updating LB list for machine", "machine", machine.Name)
}
}
return nil
}
func getGCPDecodedProviderSpec(machine machineapi.Machine) (*gcpproviderapi.GCPMachineProviderSpec, error) {
s := runtime.NewScheme()
err := gcpproviderapi.SchemeBuilder.AddToScheme(s)
if err != nil {
return nil, fmt.Errorf("Failed to register gcpproviderapi types to scheme: %v", err)
}
codecFactory := serializer.NewCodecFactory(s)
decoder := codecFactory.UniversalDecoder(gcpproviderapi.SchemeGroupVersion)
obj, gvk, err := decoder.Decode(machine.Spec.ProviderSpec.Value.Raw, nil, nil)
if err != nil {
return nil, fmt.Errorf("Could not decode GCP ProviderSpec: %v", err)
}
spec, ok := obj.(*gcpproviderapi.GCPMachineProviderSpec)
if !ok {
return nil, fmt.Errorf("Unexpected object: %#v", gvk)
}
return spec, nil
}
func encodeProviderSpec(in runtime.Object) (*runtime.RawExtension, error) {
var buf bytes.Buffer
s := runtime.NewScheme()
err := gcpproviderapi.SchemeBuilder.AddToScheme(s)
if err != nil {
return nil, fmt.Errorf("Failed to register gcpproviderapi types to scheme: %v", err)
}
codecFactory := serializer.NewCodecFactory(s)
serializerInfo := codecFactory.SupportedMediaTypes()
encoder := codecFactory.EncoderForVersion(serializerInfo[0].Serializer, gcpproviderapi.SchemeGroupVersion)
if err := encoder.Encode(in, &buf); err != nil {
return nil, fmt.Errorf("Encoding ProviderSpec failed: %v", err)
}
return &runtime.RawExtension{Raw: buf.Bytes()}, nil
}
func updateGCPLBList(kclient client.Client, oldLBList []string, newLBList []string, machineToPatch machineapi.Machine, providerSpecDecoded *gcpproviderapi.GCPMachineProviderSpec) error {
baseToPatch := client.MergeFrom(machineToPatch.DeepCopy())
if !reflect.DeepEqual(oldLBList, newLBList) {
providerSpecDecoded.TargetPools = newLBList
newProviderSpecEncoded, err := encodeProviderSpec(providerSpecDecoded)
if err != nil {
log.Error(err, "Error encoding provider spec for machine", "machine", machineToPatch.Name)
return err
}
machineToPatch.Spec.ProviderSpec.Value = newProviderSpecEncoded
machineObj := machineToPatch.DeepCopy()
if err := kclient.Patch(context.Background(), machineObj, baseToPatch); err != nil {
log.Error(err, "Failed to update LBs in machine's providerSpec", "machine", machineToPatch.Name)
return err
}
log.Info("Updated master machine's LBs in providerSpec", "masterMachine", machineToPatch.Name)
return nil
}
log.Info("No need to update LBs for master machine", "masterMachine", machineToPatch.Name)
return nil
}
func (c *Client) createExternalIP(name string, scheme string, region string) (ipAddress string, err error) {
// Check if an external IP with the correct name already exists
addyList, err := c.computeService.Addresses.List(c.projectID, region).Do()
if err != nil {
return "", fmt.Errorf("Failed to retrieve list of GCP project's IP addresses: %v", err)
}
for _, ip := range addyList.Items {
if ip.Name == name {
log.Info("Static IP has already been reserved with the correct name. Reusing.", "Name", ip.Name, "IP Address", ip.Address)
return ip.Address, nil
}
}
// Create an external IP
eip := &compute.Address{
Name: name,
AddressType: scheme,
}
insertCall := c.computeService.Addresses.Insert(c.projectID, region, eip)
eipResp, err := insertCall.Do()
if err != nil {
return "", fmt.Errorf("Request to reserve a new static IP failed: %v", err)
}
waitResp, err := c.computeService.RegionOperations.Wait(c.projectID, region, eipResp.Name).Do()
// Fail if we couldn't reserve a static IP within 2 minutes.
if waitResp.Status != "DONE" {
return "", fmt.Errorf("Failed to reserve a static IP after waiting 120s: %v", err)
}
getCall := c.computeService.Addresses.Get(c.projectID, region, name)
address, err := getCall.Do()
if err != nil {
return "", err
}
log.Info("Reserved a new static IP for external load balancer", "IP address", address.Address)
return address.Address, nil
}
func (c *Client) releaseExternalIP(region string, addressName string) error {
_, err := c.computeService.Addresses.Delete(c.projectID, region, addressName).Do()
if err != nil {
return fmt.Errorf("Failed to release External IP %v: %v", addressName, err)
}
return nil
}
func (c *Client) createNetworkLoadBalancer(name string, scheme string, targetPool string, region string, ip string) error {
//Confirm the target pool is present and get its selflink URL
tpResp, err := c.computeService.TargetPools.Get(c.projectID, region, targetPool).Do()
if err != nil {
return fmt.Errorf("Unable to find expected targetPool %v: %v", targetPool, err)
}
tpURL := tpResp.SelfLink
i := &compute.ForwardingRule{
IPAddress: ip,
Name: name,
LoadBalancingScheme: scheme,
NetworkTier: "PREMIUM",
Target: tpURL,
PortRange: "6443-6443",
IPProtocol: "TCP",
}
_, err = c.computeService.ForwardingRules.Insert(c.projectID, region, i).Do()
if err != nil {
return fmt.Errorf("Failed to create new ForwardingRule for %v: %v", name, err)
}
log.Info("Successfully created new ForwardingRule", "Name", name)
return nil
}
func (c *Client) updateAPIARecord(kclient client.Client, recordName string, newIP string) (oldIP string, err error) {
clusterDNS := &configv1.DNS{}
err = kclient.Get(context.TODO(), types.NamespacedName{Name: "cluster"}, clusterDNS)
if err != nil {
return "", err
}
pubZoneRecords, err := c.dnsService.ResourceRecordSets.List(c.projectID, clusterDNS.Spec.PublicZone.ID).Do()
if err != nil {
return "", fmt.Errorf("Failed to retrieve list of ResourceRecordSets from public zone %v : %v", clusterDNS.Spec.PublicZone.ID, err)
}
apiRRSets := []*gdnsv1.ResourceRecordSet{}
for _, rrset := range pubZoneRecords.Rrsets {
if rrset.Name == recordName {
apiRRSets = append(apiRRSets, rrset)
}
}
if len(apiRRSets) != 1 {
return "", fmt.Errorf("Expected to find 1 A record for API, found %d", len(apiRRSets))
}
oldIP = apiRRSets[0].Rrdatas[0]
if oldIP == newIP {
// A record is already pointing to the correct IP, nothing to do
log.Info("Default API A record is already pointing to the correct IP. No update necessary.", "IP address", newIP)
return oldIP, nil
}
dnsChange := &gdnsv1.Change{}
dnsChange.Deletions = append(dnsChange.Deletions, apiRRSets[0])
updatedRRSet := *apiRRSets[0]
updatedRRSet.Rrdatas = []string{newIP}
dnsChange.Additions = append(dnsChange.Additions, &updatedRRSet)
changesCall := c.dnsService.Changes.Create(c.projectID, clusterDNS.Spec.PublicZone.ID, dnsChange)
_, err = changesCall.Do()
if err != nil {
return "", err
}
return oldIP, nil
}