-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Functional demo with a new TransposeCalculator #1419
Comments
Hey Simon, you caught a bug right away! I want to assure you that the second key is correct, as Db is a homophonic key of C#, which is the MainKey of the score. |
Problem on octave solved, I've sent you the pull request. |
I believe I misunderstood your instruction. You were referring to the fact that the sharp symbol is on the wrong line of the "A" note, instead of "F," as if the Clef were for the violin and not for the bass. In this case, I assume (but I need to do some checking), that the issue lies upstream of the transposition system. |
I have created a functional demo with a new TransposeCalculator.
Features:
You can find it at this URL:
https://ammatwain.github.io/extended-transpose-calculator/
This could potentially solve some OSMD issues related to transposition.
If you have some free time, please test it and let me know if you encounter any problems.
I need to gather positive feedback before making a pull request.
Thank you for your attention.
Amedeo
https://github.com/ammatwain
Originally posted by @ammatwain in #1391 (comment)
The text was updated successfully, but these errors were encountered: