-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transpose after render changes result: Transposition to keys with more than 4 flats or sharps results in difficult sheets. #1345
Comments
Here's an example file where that issue happens (originally in E, transposing for Eb instruments (+9) results in bad readability). |
Good morning Simon, I uploaded the MusicXML file to my test area at https://ammatwain.github.io/transport-calculator/, and it is transposed correctly. |
I fixed this for our case with a hardcoded if this then that solution Basically, B-flats and E sharps can be written as just that instead of A-sharp and F-neutral, and it only occurred for those notes, so the issues we had are no longer to be seen. I would revisit this if you wanted to implement something properly though, that fixes the root problem, not just the sideeffects. |
Yes, Fredrik, my class works with equal temperament. The expected transposed note is delivered by the final link in a chain of key relationships. |
Oh now I see. Used the wrong transposition selector on your page 🙈 Your solution works great for this issue. |
Darn it... I should have put it first!... |
We're having an issue where our sheets are rendered with a more difficult to read transcription than necessary when transposing the scores to a flat key. For example a sheet in E transposed to Db:
Manually written:
![image](https://user-images.githubusercontent.com/75886490/224736607-a420667e-f296-469b-b1e0-aaa6f78e30f7.png)
Output from OSDM (+9, with the source originally in E)
![image](https://user-images.githubusercontent.com/75886490/224736919-941ef649-7236-4231-95e0-05a004743d0a.png)
As we can see, E's for example are never notated, even though they also represent the same note as D#. Same with B's, making this a bit more difficult than necessary to read.
Is it possible to fix this?
The text was updated successfully, but these errors were encountered: