Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved documentation around argument default values and basic auth example #107

Closed
Sovietaced opened this issue Oct 20, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@Sovietaced
Copy link
Contributor

It was surprisingly challenging for me to get going with basic auth. The default values of the arguments are not configured and it was not clear that I would have to explicitly disabling request signing in order to get basic auth to work (was receiving 403s).

@Sovietaced Sovietaced added enhancement New feature or request untriaged labels Oct 20, 2023
@peterzhuamazon
Copy link
Member

[Triage] Adding @prudhvigodithi to get more information on this.

@prudhvigodithi
Copy link
Collaborator

Hey @Sovietaced thanks for the feedback, can you please open a PR to fix this?
Thank you

@Sovietaced
Copy link
Contributor Author

Hey @Sovietaced thanks for the feedback, can you please open a PR to fix this?

Thank you

Yeah sure. Gimme a week.

@Sovietaced
Copy link
Contributor Author

Given that this project uses terraform-plugin-docs to manage its documentation, it appears that the behavior to document the default value is not yet supported unfortunately. hashicorp/terraform-plugin-docs#65

Feels absurd to me that the issue has been laying around for 2 years so I'll just work on adding a basic auth example :(

@Sovietaced
Copy link
Contributor Author

Ready for review: #114

@prudhvigodithi
Copy link
Collaborator

Thanks @Sovietaced I have assigned this issue to you.

@rblcoder rblcoder closed this as completed May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants