Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the classes in org.opensearch.sdk.ssl to a library that the SDK can depend on #714

Open
cwperks opened this issue Apr 28, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@cwperks
Copy link
Member

cwperks commented Apr 28, 2023

In order to implement TLS for extensions communicating with an opensearch node with the security plugin installed, many classes from the security plugin were introduced into this codebase in the org.opensearch.sdk.ssl package. They are not entirely the same, because any reference to http was removed since an extension is not an http server and the config constants were modified to remove the plugins.security prefix in front of the settings keys. There is still a lot of overlap and an opportunity to remove the duplication by placing the files related to SSL into a common library that both repositories can depend on.

See PR where extension TLS is introduced: #619

@cwperks cwperks added enhancement New feature or request untriaged labels Apr 28, 2023
@cwperks
Copy link
Member Author

cwperks commented May 2, 2023

@dbwiddis I think I found the right place to put these files. I just stumbled upon a library in core called ssl-config: https://github.com/opensearch-project/OpenSearch/tree/main/libs/ssl-config

It looks like the reindex module uses this. Whoever picks up this issue or whenever this issue gets worked on should look into transferring the files to that library in core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants